path: root/
diff options
authorwm4 <wm4@nowhere>2020-07-17 01:34:46 +0200
committerwm4 <wm4@nowhere>2020-07-20 21:02:17 +0200
commit0279a44d93a378fbdff393d6568a691817f83518 (patch)
treee81a2984f7d71cccb871f43c2c6e25c652548834 /
parentc9742413ac5eeabfdd46503f67b7393c9bd99f49 (diff)
command: extend subprocess command
Add env and detach arguments. This means the command.c code must use the "new" mp_subprocess2(). So also take this as an opportunity to clean up. win32 support gets broken by it, because it never made the switch to the newer function. The new detach parameter makes the "run" command fully redundant, but I guess we'll keep it for simplicity. But change its implementation to use mp_subprocess2() (couldn't do this earlier, because win32). Privately, I'm going to use the "env" argument to add a key binding that starts a shell with a FILE environment variable set to the currently playing file, so this is very useful to me. Note: breaks windows, so for example youtube-dl on windows will not work anymore. mp_subprocess2() has to be implemented. The old functions are gone, and subprocess-win.c is not built anymore. It will probably work on Cygwin.
Diffstat (limited to '')
1 files changed, 1 insertions, 1 deletions
diff --git a/ b/
index 7cf5d5a784..746cb16261 100644
--- a/
+++ b/
@@ -208,7 +208,7 @@ def build(ctx):
subprocess_c = ctx.pick_first_matching_dep([
( "osdep/subprocess-posix.c", "posix" ),
- ( "osdep/subprocess-win.c", "win32-desktop" ),
+ # broken ( "osdep/subprocess-win.c", "win32-desktop" ),
( "osdep/subprocess-dummy.c" ),