diff options
author | Avi Halachmi (:avih) <avihpit@yahoo.com> | 2019-09-22 01:11:02 +0300 |
---|---|---|
committer | Jan Ekström <jeebjp@gmail.com> | 2019-09-22 15:01:08 +0300 |
commit | 4cda63bd14c2087eb372fbb282fb47aea77a7923 (patch) | |
tree | 643176f7a414d6414d8ad66c8c106f315a848027 /waftools/detections | |
parent | cb32ad68f31de784a13ca5a2847143c4c37738ce (diff) | |
download | mpv-4cda63bd14c2087eb372fbb282fb47aea77a7923.tar.bz2 mpv-4cda63bd14c2087eb372fbb282fb47aea77a7923.tar.xz |
build: actually detect supported warning options
Previously the options were tested by compiling a test program with the
option, and support was "detected" if the compilation didn't fail.
However, both gcc and clang only issue a warning on unknown warning option,
hence it never failed and all the warn options were detected as supported.
Now the tested option is used together with -Werror, which makes it fail
if it warns that the warning option is unknown.
Fixes clang unknown option warnings -Wno-format-truncation since 4a6b56f .
Diffstat (limited to 'waftools/detections')
-rw-r--r-- | waftools/detections/compiler.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/waftools/detections/compiler.py b/waftools/detections/compiler.py index dcfa9f1097..c9b11f5f6d 100644 --- a/waftools/detections/compiler.py +++ b/waftools/detections/compiler.py @@ -13,8 +13,8 @@ def __get_cc_env_vars__(cc): def __test_and_add_flags__(ctx, flags): for flag in flags: - ctx.check_cc(cflags=flag, uselib_store="compiler", mandatory=False) - ctx.env.CFLAGS += ctx.env.CFLAGS_compiler + if ctx.check_cc(cflags='-Werror ' + flag, mandatory=False): + ctx.env.CFLAGS += [flag] def __add_generic_flags__(ctx): ctx.env.CFLAGS += ["-D_ISOC99_SOURCE", "-D_GNU_SOURCE", |