diff options
author | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
---|---|---|
committer | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
commit | e7db4ccf1afbb6653ae1aae44b1c96c724361985 (patch) | |
tree | 9cc7321a75460de67bd0dae4e940b73439a1374b /vidix/drivers/savage_vid.c | |
parent | 1f34ddefd2546a37c6efe4fcd9ea3f7627af4a5d (diff) | |
download | mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.bz2 mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.xz |
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård
git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2
Diffstat (limited to 'vidix/drivers/savage_vid.c')
-rw-r--r-- | vidix/drivers/savage_vid.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/vidix/drivers/savage_vid.c b/vidix/drivers/savage_vid.c index 68406ad084..ac19266591 100644 --- a/vidix/drivers/savage_vid.c +++ b/vidix/drivers/savage_vid.c @@ -82,7 +82,7 @@ /* CR69[0] = 1 : Mem-mapped regs */ #define USE_MM_FOR_PRI_STREAM_OLD 0x01 -void SavageStreamsOn(); +void SavageStreamsOn(void); /* * There are two different streams engines used in the Savage line. @@ -323,7 +323,7 @@ static struct savage_cards savage_card_ids[] = { { PCI_CHIP_PROSAVAGE_DDRK , S3_PROSAVAGE }, }; -void SavageSetColorOld() +void SavageSetColorOld(void) { @@ -360,7 +360,7 @@ void SavageSetColorOld() } } -void SavageSetColorKeyOld() +void SavageSetColorKeyOld(void) { int red, green, blue; @@ -421,8 +421,8 @@ void SavageSetColorKeyOld() static void -SavageDisplayVideoOld( -){ +SavageDisplayVideoOld(void) +{ int vgaCRIndex, vgaCRReg, vgaIOBase; unsigned int ssControl; int cr92; @@ -528,7 +528,7 @@ SavageDisplayVideoOld( } -void SavageInitStreamsOld() +void SavageInitStreamsOld(void) { /*unsigned long jDelta;*/ unsigned long format = 0; @@ -582,7 +582,7 @@ void SavageInitStreamsOld() } void -SavageStreamsOn() +SavageStreamsOn(void) { unsigned char jStreamsControl; unsigned short vgaCRIndex = 0x3d0 + 4; @@ -726,7 +726,7 @@ static void savage_getscreenproperties(struct savage_info *info){ } -void SavageStreamsOff() +void SavageStreamsOff(void) { unsigned char jStreamsControl; unsigned short vgaCRIndex = 0x3d0 + 4; |