vo_opengl: gl_lcms: fix potential dangling pointer issue

If icc-path is set, but the thing is replaced with a memory profile,
then p->icc_path would point to deallocated memory.

Also, the NULL checks are unnecessary.

1 files changed, 5 insertions, 4 deletions

diff --git a/video/out/gl_lcms.c b/video/out/gl_lcms.c
index 254826bb15..7f6b54e38e 100644
--- a/video/out/gl_lcms.c
+++ b/video/out/gl_lcms.c
@@ -145,16 +145,17 @@ void gl_lcms_set_options(struct gl_lcms *p, struct mp_icc_opts *opts)
     load_profile(p);
 }
 
+// Warning: profile.start must point to a ta allocation, and the function
+//          takes over ownership.
 void gl_lcms_set_memory_profile(struct gl_lcms *p, bstr *profile)
 {
     if (!p->opts.profile_auto)
         return;
 
-    if (p->icc_path)
-        talloc_free(p->icc_path);
+    talloc_free(p->icc_path);
+    p->icc_path = NULL;
 
-    if (p->icc_data)
-        talloc_free(p->icc_data);
+    talloc_free(p->icc_data);
 
     p->icc_data = talloc_steal(p, profile->start);
     p->icc_size = profile->len;