path: root/video/out/vulkan/context.c
diff options
authorDudemanguy <>2020-09-18 12:29:53 -0500
committerDudemanguy <>2020-09-21 20:42:17 +0000
commitefb0c5c4469ce4dc63fc3345293bdf7536e36581 (patch)
tree051f59036b59009114b3f4da05043226fbdc85be /video/out/vulkan/context.c
parent9ba90b4f6ff06bcc2a131237df9df1078c75d9d8 (diff)
wayland: only render if we have frame callback
Back in the olden days, mpv's wayland backend was driven by the frame callback. This had several issues and was removed in favor of the current approach which allowed some advanced features (like display-resample and presentation time) to actually work properly. However as a consequence, it meant that mpv always rendered, even if the surface was hidden. Wayland people consider this "wasteful" (and well they aren't wrong). This commit aims to avoid wasteful rendering by doing some additional checks in the swapchain. There's three main parts to this. 1. Wayland EGL now uses an external swapchain (like the drm context). Before we start a new frame, we check to see if we are waiting on a callback from the compositor. If there is no wait, then go ahead and proceed to render the frame, swap buffers, and then initiate vo_wayland_wait_frame to poll (with a timeout) for the next potential callback. If we are still waiting on callback from the compositor when starting a new frame, then we simple skip rendering it entirely until the surface comes back into view. 2. Wayland on vulkan has essentially the same approach although the details are a little different. The ra_vk_ctx does not have support for an external swapchain and although such a mechanism could theoretically be added, it doesn't make much sense with libplacebo. Instead, start_frame was added as a param and used to check for callback. 3. For wlshm, it's simply a matter of adding frame callback to it, leveraging vo_wayland_wait_frame, and using the frame callback value to whether or not to draw the image.
Diffstat (limited to 'video/out/vulkan/context.c')
1 files changed, 5 insertions, 0 deletions
diff --git a/video/out/vulkan/context.c b/video/out/vulkan/context.c
index 4d94c6fb77..3518d3efd2 100644
--- a/video/out/vulkan/context.c
+++ b/video/out/vulkan/context.c
@@ -229,6 +229,11 @@ static bool start_frame(struct ra_swapchain *sw, struct ra_fbo *out_fbo)
struct priv *p = sw->priv;
struct pl_swapchain_frame frame;
+ bool start = true;
+ if (p->params.start_frame)
+ start = p->params.start_frame(sw->ctx);
+ if (!start)
+ return false;
if (!pl_swapchain_start_frame(p->swapchain, &frame))
return false;
if (!mppl_wrap_tex(sw->ctx->ra, frame.fbo, &p->proxy_tex))