diff options
| author | Stefano Pigozzi <stefano.pigozzi@gmail.com> | 2013-07-16 13:28:28 +0200 |
|---|---|---|
| committer | Stefano Pigozzi <stefano.pigozzi@gmail.com> | 2013-11-03 21:59:54 +0100 |
| commit | 37388ebb0ef9085c841d7f94e665a5a77cfe0e92 (patch) | |
| tree | b47d18bee4e7f661d9e6d794dac0ec1cebcd3a37 /video/out/vo_corevideo.c | |
| parent | 891a2a1f474add323145e6b2cd2d29181830e4a4 (diff) | |
| download | mpv-37388ebb0ef9085c841d7f94e665a5a77cfe0e92.tar.bz2 mpv-37388ebb0ef9085c841d7f94e665a5a77cfe0e92.tar.xz | |
configure: uniform the defines to #define HAVE_xxx (0|1)
The configure followed 5 different convetions of defines because the next guy
always wanted to introduce a new better way to uniform it[1]. For an
hypothetic feature 'hurr' you could have had:
* #define HAVE_HURR 1 / #undef HAVE_DURR
* #define HAVE_HURR / #undef HAVE_DURR
* #define CONFIG_HURR 1 / #undef CONFIG_DURR
* #define HAVE_HURR 1 / #define HAVE_DURR 0
* #define CONFIG_HURR 1 / #define CONFIG_DURR 0
All is now uniform and uses:
* #define HAVE_HURR 1
* #define HAVE_DURR 0
We like definining to 0 as opposed to `undef` bcause it can help spot typos
and is very helpful when doing big reorganizations in the code.
[1]: http://xkcd.com/927/ related
Diffstat (limited to 'video/out/vo_corevideo.c')
| -rw-r--r-- | video/out/vo_corevideo.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/video/out/vo_corevideo.c b/video/out/vo_corevideo.c index 58eb711cec..7b34a91924 100644 --- a/video/out/vo_corevideo.c +++ b/video/out/vo_corevideo.c @@ -23,7 +23,7 @@ #include "config.h" #include <QuartzCore/QuartzCore.h> -#if CONFIG_VDA +#if HAVE_VDA_HWACCEL #include <IOSurface/IOSurface.h> #endif @@ -446,7 +446,7 @@ static struct cv_functions cv_functions = { .set_yuv_colorspace = cv_set_yuv_colorspace, }; -#if CONFIG_VDA +#if HAVE_VDA_HWACCEL static void iosurface_init(struct vo *vo) { struct priv *p = vo->priv; @@ -546,7 +546,7 @@ static struct cv_functions iosurface_functions = { .get_yuv_colorspace = get_yuv_colorspace, .set_yuv_colorspace = iosurface_set_yuv_csp, }; -#endif /* CONFIG_VDA */ +#endif /* HAVE_VDA_HWACCEL */ static int query_format(struct vo *vo, uint32_t format) { @@ -554,7 +554,7 @@ static int query_format(struct vo *vo, uint32_t format) const int flags = VFCAP_CSP_SUPPORTED | VFCAP_CSP_SUPPORTED_BY_HW; switch (format) { -#if CONFIG_VDA +#if HAVE_VDA_HWACCEL case IMGFMT_VDA: p->fns = iosurface_functions; return flags; |