summaryrefslogtreecommitdiffstats
path: root/video/out/placebo/ra_pl.c
diff options
context:
space:
mode:
authorPhilip Langdale <philipl@cloudera.com>2019-06-13 12:30:18 -0700
committersfan5 <sfan5@live.de>2019-07-08 00:59:28 +0200
commite2976e662d9215b5a466b108efc89e19fc718616 (patch)
treead5b58e82af5477dfe640e775efad85f2b45de25 /video/out/placebo/ra_pl.c
parentc379950ce08932dec839f18926183c7b05b57d00 (diff)
downloadmpv-e2976e662d9215b5a466b108efc89e19fc718616.tar.bz2
mpv-e2976e662d9215b5a466b108efc89e19fc718616.tar.xz
video/out/gpu: Add a `storable` flag to ra_format
While `ra` supports the concept of a texture as a storage destination, it does not support the concept of a texture format being usable for a storage texture. This can lead to us attempting to create a texture from an incompatible format, with undefined results. So, let's introduce an explicit format flag for storage and use it. In `ra_pl` we can simply reflect the `storable` flag. For GL and D3D, we'll need to write some new code to do the compatibility checks. I'm not going to do it here because it's not a regression; we were already implicitly assuming all formats were storable. Fixes #6657
Diffstat (limited to 'video/out/placebo/ra_pl.c')
-rw-r--r--video/out/placebo/ra_pl.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/video/out/placebo/ra_pl.c b/video/out/placebo/ra_pl.c
index 18d8f37070..28d4297f6f 100644
--- a/video/out/placebo/ra_pl.c
+++ b/video/out/placebo/ra_pl.c
@@ -88,6 +88,7 @@ struct ra *ra_create_pl(const struct pl_gpu *gpu, struct mp_log *log)
.pixel_size = plfmt->texel_size,
.linear_filter = plfmt->caps & PL_FMT_CAP_LINEAR,
.renderable = plfmt->caps & PL_FMT_CAP_RENDERABLE,
+ .storable = plfmt->caps & PL_FMT_CAP_STORABLE,
.glsl_format = plfmt->glsl_format,
};