diff options
author | wm4 <wm4@nowhere> | 2017-11-07 05:29:26 +0100 |
---|---|---|
committer | wm4 <wm4@nowhere> | 2017-11-07 05:29:26 +0100 |
commit | 793b43020c784047b60a7b9f3461ff3b9fe90d02 (patch) | |
tree | 5f4a9f8df0b4d040d36683db8aae1408d4bf1479 /video/out/opengl | |
parent | a2a623ebb9309d05113bd400449b618aa21f783f (diff) | |
download | mpv-793b43020c784047b60a7b9f3461ff3b9fe90d02.tar.bz2 mpv-793b43020c784047b60a7b9f3461ff3b9fe90d02.tar.xz |
vo_lavc: remove messy delayed subtitle rendering logic
For some reason vo_lavc's draw_image can buffer the frame and encode it
only later. Also, there is logic for rendering the OSD (i.e. subtitles)
only when needed.
In theory this can lead to subtitles being pruned before it tries to
render them (as the subtitle logic doesn't know that the VO still needs
them later), although this probably never happens in reality.
The worse issue, that actually happened, is that if the last frame gets
buffered, it attempts to render subtitles in the uninit callback. At
this point, the subtitle decoder is already torn down and all subtitles
removed, thus it will draw nothing. This didn't always happen. I'm not
sure why - potentially in the working cases, the frame wasn't buffered.
Since this logic doesn't have much worth, except a minor performance
advantage if frames with subtitles are dropped, just remove it.
Hopefully fixes #4689.
Diffstat (limited to 'video/out/opengl')
0 files changed, 0 insertions, 0 deletions