vo: simplify VOs by adding generic screenshot support

At the time screenshot support was added, images weren't refcounted yet,
so screenshots required specialized implementations in the VOs. But now
we can handle these things much simpler. Also see commit 5bb24980.

If there are VOs in the future which can't do this (e.g. they need to
write to the image passed to vo_driver->draw_image), this still could be
disabled on a per-VO basis etc., so we lose no potential performance
advantages.

1 files changed, 0 insertions, 6 deletions

diff --git a/video/out/gl_video.c b/video/out/gl_video.c
index 2eeb86f353..bc1e04b0e6 100644
--- a/video/out/gl_video.c
+++ b/video/out/gl_video.c
@@ -2188,12 +2188,6 @@ void gl_video_upload_image(struct gl_video *p, struct mp_image *mpi)
         gl->BindBuffer(GL_PIXEL_UNPACK_BUFFER, 0);
 }
 
-struct mp_image *gl_video_download_image(struct gl_video *p)
-{
-    struct video_image *vimg = &p->image;
-    return vimg->mpi ? mp_image_new_ref(vimg->mpi) : NULL;
-}
-
 static void draw_osd_cb(void *ctx, struct sub_bitmaps *imgs)
 {
     struct gl_video *p = ctx;