diff options
| author | Stefano Pigozzi <stefano.pigozzi@gmail.com> | 2013-07-16 13:28:28 +0200 |
|---|---|---|
| committer | Stefano Pigozzi <stefano.pigozzi@gmail.com> | 2013-11-03 21:59:54 +0100 |
| commit | 37388ebb0ef9085c841d7f94e665a5a77cfe0e92 (patch) | |
| tree | b47d18bee4e7f661d9e6d794dac0ec1cebcd3a37 /video/image_writer.c | |
| parent | 891a2a1f474add323145e6b2cd2d29181830e4a4 (diff) | |
| download | mpv-37388ebb0ef9085c841d7f94e665a5a77cfe0e92.tar.bz2 mpv-37388ebb0ef9085c841d7f94e665a5a77cfe0e92.tar.xz | |
configure: uniform the defines to #define HAVE_xxx (0|1)
The configure followed 5 different convetions of defines because the next guy
always wanted to introduce a new better way to uniform it[1]. For an
hypothetic feature 'hurr' you could have had:
* #define HAVE_HURR 1 / #undef HAVE_DURR
* #define HAVE_HURR / #undef HAVE_DURR
* #define CONFIG_HURR 1 / #undef CONFIG_DURR
* #define HAVE_HURR 1 / #define HAVE_DURR 0
* #define CONFIG_HURR 1 / #define CONFIG_DURR 0
All is now uniform and uses:
* #define HAVE_HURR 1
* #define HAVE_DURR 0
We like definining to 0 as opposed to `undef` bcause it can help spot typos
and is very helpful when doing big reorganizations in the code.
[1]: http://xkcd.com/927/ related
Diffstat (limited to 'video/image_writer.c')
| -rw-r--r-- | video/image_writer.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/video/image_writer.c b/video/image_writer.c index 22192ade45..d2ef348d87 100644 --- a/video/image_writer.c +++ b/video/image_writer.c @@ -27,7 +27,7 @@ #include "config.h" -#ifdef CONFIG_JPEG +#if HAVE_JPEG #include <jpeglib.h> #endif @@ -142,7 +142,7 @@ error_exit: return success; } -#ifdef CONFIG_JPEG +#if HAVE_JPEG static void write_jpeg_error_exit(j_common_ptr cinfo) { @@ -226,7 +226,7 @@ static const struct img_writer img_writers[] = { .pixfmts = (int[]) { IMGFMT_BGR24, IMGFMT_BGRA, IMGFMT_BGR15_LE, IMGFMT_Y8, 0}, }, -#ifdef CONFIG_JPEG +#if HAVE_JPEG { "jpg", write_jpeg }, { "jpeg", write_jpeg }, #endif |