diff options
author | wm4 <wm4@nowhere> | 2012-10-04 17:16:36 +0200 |
---|---|---|
committer | wm4 <wm4@nowhere> | 2012-10-16 07:26:32 +0200 |
commit | 05f4f00e24caf23646a2b551b8e1a1a1abe76de7 (patch) | |
tree | f7f5684385025a9a7dfe22082209ddc266a3059b /sub/sd.h | |
parent | 17f5019b468d5269408b7dae53a24e17426de7d5 (diff) | |
download | mpv-05f4f00e24caf23646a2b551b8e1a1a1abe76de7.tar.bz2 mpv-05f4f00e24caf23646a2b551b8e1a1a1abe76de7.tar.xz |
sub: cleanup: don't pass parameters via global variables
Passing parameters from caller to subtitle renderer was done by
temporarily setting certain members in the osd_state struct (which for
all practical purposes are as good as global variables). This was the
only purpose of these members.
Rather than using such a messy way to pass parameter, put these into a
struct sub_render_params. The struct was already introduced in earlier
commits, and this commit just removes the parameter passing hack.
Diffstat (limited to 'sub/sd.h')
-rw-r--r-- | sub/sd.h | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -2,6 +2,7 @@ #define MPLAYER_SD_H struct osd_state; +struct sub_render_params; struct sh_sub; struct sub_bitmaps; @@ -10,6 +11,7 @@ struct sd_functions { void (*decode)(struct sh_sub *sh, struct osd_state *osd, void *data, int data_len, double pts, double duration); void (*get_bitmaps)(struct sh_sub *sh, struct osd_state *osd, + struct sub_render_params *params, struct sub_bitmaps *res); void (*reset)(struct sh_sub *sh, struct osd_state *osd); void (*switch_off)(struct sh_sub *sh, struct osd_state *osd); |