diff options
author | wm4 <wm4@nowhere> | 2018-04-28 18:14:43 +0200 |
---|---|---|
committer | Jan Ekström <jeebjp@gmail.com> | 2018-04-29 02:21:32 +0300 |
commit | 7dd69ef77c6aa80067c13f76aa0b78d63fbc4eda (patch) | |
tree | 58036a7590ed3007b5ffa2ea9e3ee566586f79d9 /stream/stream_libarchive.c | |
parent | 573159734271c3969ffb3818af9dde3b116f9c92 (diff) | |
download | mpv-7dd69ef77c6aa80067c13f76aa0b78d63fbc4eda.tar.bz2 mpv-7dd69ef77c6aa80067c13f76aa0b78d63fbc4eda.tar.xz |
command: change cycle-value command behavior
Instead of using an internal counter to keep track of the value that was
set last, attempt to find the current value of the property/option in
the value list, and then set the next value in the list.
There are some potential problems. If a property refuses to accept a
specific value, the cycle-values command will fail, and start from the
same position again. It can't know that it's supposed to skip the next
value. The same can happen to properties which behave "strangely", such
as the "aspect" property, which will return the current aspect if you
write "-1" to it. As a consequence, cycle-values can appear to get
"stuck".
I still think the new behavior is what users expect more, and which is
generally more useful. We won't restore the ability to get the old
behavior, unless we decide to revert this commit entirely.
Fixes #5772, and hopefully other complaints.
Diffstat (limited to 'stream/stream_libarchive.c')
0 files changed, 0 insertions, 0 deletions