diff options
author | wm4 <wm4@nowhere> | 2013-06-21 20:16:52 +0200 |
---|---|---|
committer | wm4 <wm4@nowhere> | 2013-06-25 00:11:55 +0200 |
commit | 3993f551df715447223ee77cd79e8504d89e7862 (patch) | |
tree | da2d9e96f4ff2c028f38b54760214a3869e742c8 /stream/stream.c | |
parent | 4d33197547ec0334eb64d02b65b907b6a6dd107f (diff) | |
download | mpv-3993f551df715447223ee77cd79e8504d89e7862.tar.bz2 mpv-3993f551df715447223ee77cd79e8504d89e7862.tar.xz |
stream: never let read functions return values < 0
stream_read_unbuffered() can sometimes return negative values on error.
Change that to return 0 - the negative values are nowhere used anyway.
If distinguishing errors and EOF is really needed, a flag could be added
instead.
This also fixes the stream_read_partial() call in cache.c, which assumes
the return values is always >= 0.
Diffstat (limited to 'stream/stream.c')
-rw-r--r-- | stream/stream.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/stream/stream.c b/stream/stream.c index ba05202b53..c70a593294 100644 --- a/stream/stream.c +++ b/stream/stream.c @@ -379,7 +379,9 @@ static int stream_read_unbuffered(stream_t *s, void *buf, int len) default: len = s->fill_buffer ? s->fill_buffer(s, buf, len) : 0; } - if (len <= 0) { + if (len < 0) + len = 0; + if (len == 0) { // do not retry if this looks like proper eof if (s->eof || (s->end_pos && s->pos == s->end_pos)) goto eof_out; @@ -426,12 +428,12 @@ int stream_fill_buffer(stream_t *s) { int len = stream_read_unbuffered(s, s->buffer, STREAM_BUFFER_SIZE); s->buf_pos = 0; - s->buf_len = len < 0 ? 0 : len; + s->buf_len = len; return s->buf_len; } // Read between 1..buf_size bytes of data, return how much data has been read. -// Return <= 0 on EOF, error, of if buf_size was 0. +// Return 0 on EOF, error, of if buf_size was 0. int stream_read_partial(stream_t *s, char *buf, int buf_size) { assert(s->buf_pos <= s->buf_len); |