diff options
| author | wm4 <wm4@nowhere> | 2014-09-04 23:35:11 +0200 |
|---|---|---|
| committer | Alessandro Ghedini <alessandro@ghedini.me> | 2014-09-05 12:01:26 +0200 |
| commit | 1871f2a703d5863d9839427a6c9de9d0cf281846 (patch) | |
| tree | c12ecea7e5c6750c6d4c647809b0c24e70c1b4c9 /player/loadfile.c | |
| parent | 4a8e5ea26922f57287c04e3c548c574d7e334f44 (diff) | |
| download | mpv-1871f2a703d5863d9839427a6c9de9d0cf281846.tar.bz2 mpv-1871f2a703d5863d9839427a6c9de9d0cf281846.tar.xz | |
audio: fix obscure audio resync failure with timelines
Somehow, there was a larger misunderstanding in the code: ao_buffer
does not need to be preserved over audio reinit for proper support of
gapless audio. The actual AO internal buffer takes care of this.
In fact, preserving ao_buffer just breaks audio resync. In the ordered
chapter case, end_pts is used, which means not all audio data in the
buffer is played, thus some data is left over when audio decoding
resumes on the next segment. This triggers some code that aborts resync
if there's "audio decoded" (ao_buffer contains something), but no PTS
is known (nothing was actually decoded yet).
Simplify, and always bind the output buffer to the decoder.
CC: @mpv-player/stable (maybe)
Diffstat (limited to 'player/loadfile.c')
| -rw-r--r-- | player/loadfile.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/player/loadfile.c b/player/loadfile.c index 119362bd3b..6431feedb4 100644 --- a/player/loadfile.c +++ b/player/loadfile.c @@ -86,8 +86,11 @@ void uninit_player(struct MPContext *mpctx, unsigned int mask) mixer_uninit_audio(mpctx->mixer); audio_uninit(mpctx->d_audio); mpctx->d_audio = NULL; + talloc_free(mpctx->ao_buffer); mpctx->audio_status = STATUS_EOF; reselect_demux_streams(mpctx); + if (mpctx->ao_buffer) + mp_audio_buffer_clear(mpctx->ao_buffer); } if (mask & INITIALIZED_SUB) { |