summaryrefslogtreecommitdiffstats
path: root/player/client.h
diff options
context:
space:
mode:
authorwnoun <wnoun@outlook.com>2019-05-26 16:58:25 +0800
committerwm4 <wm4@nowhere>2019-09-20 13:54:17 +0200
commit35da5a4d8e9f8616eaa55af3219cbb6139d6d68c (patch)
tree7f8ba179101bedea7d545448fa3442bfa26871e4 /player/client.h
parentdb09d77e46128a68f06dc89d34bdc6045ace63f2 (diff)
downloadmpv-35da5a4d8e9f8616eaa55af3219cbb6139d6d68c.tar.bz2
mpv-35da5a4d8e9f8616eaa55af3219cbb6139d6d68c.tar.xz
render api: fix use-after-free
render api needs to wait for vo to be destroyed before frees the context. The purpose of kill_cb is to wake up render api after vo is destroyed, but uninit did that before kill_cb, so kill_cb tries using the freed memory. Remove kill_cb to fix the issue as uninit is able to do the work.
Diffstat (limited to 'player/client.h')
-rw-r--r--player/client.h3
1 files changed, 1 insertions, 2 deletions
diff --git a/player/client.h b/player/client.h
index 7426e94372..e9e8665e70 100644
--- a/player/client.h
+++ b/player/client.h
@@ -49,8 +49,7 @@ bool mp_set_main_render_context(struct mp_client_api *client_api,
struct mpv_render_context *ctx, bool active);
struct mpv_render_context *
mp_client_api_acquire_render_context(struct mp_client_api *ca);
-void kill_video_async(struct mp_client_api *client_api, void (*fin)(void *ctx),
- void *fin_ctx);
+void kill_video_async(struct mp_client_api *client_api);
bool mp_streamcb_lookup(struct mpv_global *g, const char *protocol,
void **out_user_data, mpv_stream_cb_open_ro_fn *out_fn);