summaryrefslogtreecommitdiffstats
path: root/player/client.c
diff options
context:
space:
mode:
authorwm4 <wm4@nowhere>2014-06-01 03:41:46 +0200
committerwm4 <wm4@nowhere>2014-06-01 03:41:46 +0200
commit5a5a3c53f75a093b1a0642174cdbd5a9504e083f (patch)
tree73aa81a8a15c4dd0636551c1797fb621010fa13a /player/client.c
parentc84f8735960fc3af6c50d0af675dfe9593174be5 (diff)
downloadmpv-5a5a3c53f75a093b1a0642174cdbd5a9504e083f.tar.bz2
mpv-5a5a3c53f75a093b1a0642174cdbd5a9504e083f.tar.xz
client API: report success status when running commands
Until now, an error was reported only if the command couldn't be parsed. Attempt to do more fine-grained reporting. This is not necessarily perfect, but it's an improvement.
Diffstat (limited to 'player/client.c')
-rw-r--r--player/client.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/player/client.c b/player/client.c
index 0a71e5020d..ba3705a9af 100644
--- a/player/client.c
+++ b/player/client.c
@@ -717,8 +717,8 @@ struct cmd_request {
static void cmd_fn(void *data)
{
struct cmd_request *req = data;
- run_command(req->mpctx, req->cmd);
- req->status = 0;
+ int r = run_command(req->mpctx, req->cmd);
+ req->status = r >= 0 ? 0 : MPV_ERROR_COMMAND;
talloc_free(req->cmd);
if (req->reply_ctx) {
status_reply(req->reply_ctx, MPV_EVENT_COMMAND_REPLY,
@@ -1305,6 +1305,7 @@ static const char *err_table[] = {
[-MPV_ERROR_PROPERTY_FORMAT] = "unsupported format for accessing property",
[-MPV_ERROR_PROPERTY_UNAVAILABLE] = "property unavailable",
[-MPV_ERROR_PROPERTY_ERROR] = "error accessing property",
+ [-MPV_ERROR_COMMAND] = "error running command",
};
const char *mpv_error_string(int error)