options: deprecate --loop

Also "announce" the plans to undeprecate it with changed semantics
later. The deprecation period is needed to warn script authors and
client API users (etc.) of the change.

This is done because everyone seems to expect --loop to loop the current
file, not the playlist. Even in cases when only 1 file is on the
playlist, the --loop-file semantics seem to be preferred.

1 files changed, 9 insertions, 5 deletions

diff --git a/options/m_config.c b/options/m_config.c
index 14aa56da51..16a0b38eb1 100644
--- a/options/m_config.c
+++ b/options/m_config.c
@@ -624,12 +624,16 @@ struct m_config_option *m_config_get_co(const struct m_config *config,
     const char *prefix = config->is_toplevel ? "--" : "";
     if (co->opt->type == &m_option_type_alias) {
         const char *alias = (const char *)co->opt->priv;
-        // deprecation_message is not used, but decides whether it's a
-        // proper or deprecated alias.
         if (co->opt->deprecation_message && !co->warning_was_printed) {
-            MP_WARN(config, "Warning: option %s%s was replaced with "
-                    "%s%s and might be removed in the future.\n",
-                    prefix, co->name, prefix, alias);
+            if (co->opt->deprecation_message[0]) {
+                MP_WARN(config, "Warning: option %s%s was replaced with "
+                        "%s%s: %s\n", prefix, co->name, prefix, alias,
+                        co->opt->deprecation_message);
+            } else {
+                MP_WARN(config, "Warning: option %s%s was replaced with "
+                        "%s%s and might be removed in the future.\n",
+                        prefix, co->name, prefix, alias);
+            }
             co->warning_was_printed = true;
         }
         return m_config_get_co(config, bstr0(alias));