diff options
author | wm4 <wm4@nowhere> | 2013-10-12 16:51:41 +0200 |
---|---|---|
committer | wm4 <wm4@nowhere> | 2013-10-12 18:56:03 +0200 |
commit | d1c473bc258b863f8619ffaf7d70112136ef1039 (patch) | |
tree | cb33277af7f6fc6f63e3d31b3a934103ecc3e994 /mpvcore/m_property.c | |
parent | 57c3fca7a8f6700b3c35acda290af7133f277c13 (diff) | |
download | mpv-d1c473bc258b863f8619ffaf7d70112136ef1039.tar.bz2 mpv-d1c473bc258b863f8619ffaf7d70112136ef1039.tar.xz |
libquvi9: work around insane interaction between libquvi and libkdecore
The primary effect of this commit is that it fixes playback resume if
libquvi 0.9 and German locale are used, and libkdecore is on the system.
(See github issue #279.)
libquvi uses libproxy to determine system-wide proxy settings. libproxy
in turn loads libkdecore (if present) to determine KDE proxy settings.
libkdecore has a global constructor, which calls setlocale(LC_ALL, ""),
switching the current locale from "C" to what the user's settings. This
breaks some basic C string processing functions. Note that the locale
won't be set on program start, but only when libproxy calls dlopen() on
its config_kde module, which actually causes libkdecore to be loaded and
initialized.
In particular, with German locale, snprintf() would use "," instead of
"." when formatting float values, which in combination with playback
resume, would lead to parse errors the next time mpv was started, which
is how this issue was found.
I'd consider this a bug with libkdecore or at least libproxy. No library
should ever even touch locale: it might break basic expectations on C
string handling functions, might override program settings, and it's not
thread-safe. But this is so nasty and severe, that a quick hack to fix
it hurts less.
See github issue #279 and KDE bug #325902.
Diffstat (limited to 'mpvcore/m_property.c')
0 files changed, 0 insertions, 0 deletions