diff options
author | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
---|---|---|
committer | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
commit | e7db4ccf1afbb6653ae1aae44b1c96c724361985 (patch) | |
tree | 9cc7321a75460de67bd0dae4e940b73439a1374b /mplayer.c | |
parent | 1f34ddefd2546a37c6efe4fcd9ea3f7627af4a5d (diff) | |
download | mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.bz2 mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.xz |
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård
git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2
Diffstat (limited to 'mplayer.c')
-rw-r--r-- | mplayer.c | 8 |
1 files changed, 4 insertions, 4 deletions
@@ -189,7 +189,7 @@ static int max_framesize=0; #include "libmpcodecs/vf.h" #include "libmpcodecs/vd.h" -extern void vf_list_plugins(); +extern void vf_list_plugins(void); //**************************************************************************// //**************************************************************************// @@ -764,7 +764,7 @@ int playtree_add_playlist(play_tree_t* entry) static int play_tree_step = 1; -int sub_source() +int sub_source(void) { int source = -1; int top = -1; @@ -807,7 +807,7 @@ void add_subtitles(char *filename, float fps, int silent) } // FIXME: if/when the GUI calls this, global sub numbering gets (potentially) broken. -void update_set_of_subtitles() +void update_set_of_subtitles(void) // subdata was changed, set_of_sub... have to be updated. { int i; @@ -1022,7 +1022,7 @@ static int build_afilter_chain(sh_audio_t *sh_audio, ao_data_t *ao_data) * which need to be fixed while watching the movie. */ -static void log_sub(){ +static void log_sub(void){ char *fname; FILE *f; int i; |