summaryrefslogtreecommitdiffstats
path: root/mp_core.h
diff options
context:
space:
mode:
authorwm4 <wm4@nowhere>2012-08-03 05:55:02 +0200
committerwm4 <wm4@nowhere>2012-08-03 05:55:02 +0200
commitb4d9647d189a6bb924fc6b415ae18969885f11f1 (patch)
treef794e727435ef230f52dd1fac7c0f7029dc7b083 /mp_core.h
parent11648493db7db164aa8fe01751b7e5c5e5faa810 (diff)
downloadmpv-b4d9647d189a6bb924fc6b415ae18969885f11f1.tar.bz2
mpv-b4d9647d189a6bb924fc6b415ae18969885f11f1.tar.xz
mplayer: do not create X11 state in player frontend
This is about the vo_x11_init_state() call. It basically opens a X11 connection. It's called in the main() function once. It's not really clear why this isn't done on VO creation instead. Maybe one reason was that --no-fixed-vo used to be the default: when playing a new file, the full VO state would be free'd and recreated. Keeping the X11 connection possibly improved things, although the question is how. In summary, there is no good reason to do this, and it only adds platform specific details to the player frontend. Do the X11 initialization in the respective VOs instead.
Diffstat (limited to 'mp_core.h')
-rw-r--r--mp_core.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/mp_core.h b/mp_core.h
index 70ad8a89a7..49cc81a8e1 100644
--- a/mp_core.h
+++ b/mp_core.h
@@ -82,7 +82,6 @@ struct chapter {
typedef struct MPContext {
struct MPOpts opts;
struct m_config *mconfig;
- struct vo_x11_state *x11_state;
struct mp_fifo *key_fifo;
struct input_ctx *input;
struct osd_state *osd;