diff options
author | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
---|---|---|
committer | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
commit | e7db4ccf1afbb6653ae1aae44b1c96c724361985 (patch) | |
tree | 9cc7321a75460de67bd0dae4e940b73439a1374b /libmpdemux/demux_ty_osd.c | |
parent | 1f34ddefd2546a37c6efe4fcd9ea3f7627af4a5d (diff) | |
download | mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.bz2 mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.xz |
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård
git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2
Diffstat (limited to 'libmpdemux/demux_ty_osd.c')
-rw-r--r-- | libmpdemux/demux_ty_osd.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/libmpdemux/demux_ty_osd.c b/libmpdemux/demux_ty_osd.c index 17f27e429f..d68c7a5ff7 100644 --- a/libmpdemux/demux_ty_osd.c +++ b/libmpdemux/demux_ty_osd.c @@ -63,7 +63,7 @@ static subtitle *ty_pOSD2; static int tyOSDInited = 0; static int tyOSDUpdate = 0; -static void ty_DrawOSD() +static void ty_DrawOSD(void) { // printf( "Calling ty_DrawOSD()\n" ); tyOSDUpdate = 1; @@ -161,7 +161,7 @@ static void ty_drawchar( char c ) *( TY_CC_ptr++ ) = ( c == 14 ) ? '/' : c; // swap a '/' for musical note } -static void ty_draw() +static void ty_draw(void) { if ( TY_CC_ptr != TY_CC_buf && TY_OSD_flags & TY_TEXT_MODE ) { @@ -513,7 +513,7 @@ static void ty_AddXDSToDisplay( char *format, ... ) } -static void ty_DisplayXDSInfo() +static void ty_DisplayXDSInfo(void) { int index; int size; |