Patch by Stefan Huehner / stefan % huehner ! org \

patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.

Comments about a similar patch applied to ffmpeg:

That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter

Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård


git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2

1 files changed, 3 insertions, 3 deletions

diff --git a/libmpdemux/cue_read.c b/libmpdemux/cue_read.c
index 4485f2ddc3..ecd568fa27 100644
--- a/libmpdemux/cue_read.c
+++ b/libmpdemux/cue_read.c
@@ -268,7 +268,7 @@ static inline int cue_msf_2_sector(int minute, int second, int frame) {
  return frame + (second + minute * 60 ) * 75;
 }
 
-static inline int cue_get_msf() {
+static inline int cue_get_msf(void) {
   return cue_msf_2_sector (cue_current_pos.minute,
                            cue_current_pos.second,
                            cue_current_pos.frame);
@@ -433,7 +433,7 @@ static int cue_read_cue (char *in_cue_filename)
 
 
 
-static int cue_read_toc_entry() {
+static int cue_read_toc_entry(void) {
 
   int track = cue_current_pos.track - 1;
 
@@ -480,7 +480,7 @@ static int cue_vcd_get_track_end (int track){
   return VCD_SECTOR_DATA * cue_get_msf();
 }
 
-static void cue_vcd_read_toc(){
+static void cue_vcd_read_toc(void){
   int i;
   for (i = 0; i < nTracks; ++i) {