diff options
author | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
---|---|---|
committer | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
commit | e7db4ccf1afbb6653ae1aae44b1c96c724361985 (patch) | |
tree | 9cc7321a75460de67bd0dae4e940b73439a1374b /libmpcodecs/native | |
parent | 1f34ddefd2546a37c6efe4fcd9ea3f7627af4a5d (diff) | |
download | mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.bz2 mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.xz |
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård
git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2
Diffstat (limited to 'libmpcodecs/native')
-rw-r--r-- | libmpcodecs/native/xa_gsm.c | 2 | ||||
-rw-r--r-- | libmpcodecs/native/xa_gsm.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/libmpcodecs/native/xa_gsm.c b/libmpcodecs/native/xa_gsm.c index 4c12d5471d..546edf81dc 100644 --- a/libmpcodecs/native/xa_gsm.c +++ b/libmpcodecs/native/xa_gsm.c @@ -40,7 +40,7 @@ static void Gsm_RPE_Decoding(); static XA_GSM_STATE gsm_state; -void GSM_Init() +void GSM_Init(void) { memset((char *)(&gsm_state), 0, sizeof(XA_GSM_STATE)); gsm_state.nrp = 40; diff --git a/libmpcodecs/native/xa_gsm.h b/libmpcodecs/native/xa_gsm.h index 212fbe0e97..232a7761e4 100644 --- a/libmpcodecs/native/xa_gsm.h +++ b/libmpcodecs/native/xa_gsm.h @@ -1,6 +1,6 @@ void XA_MSGSM_Decoder(unsigned char *ibuf,unsigned short *obuf); void XA_GSM_Decoder(unsigned char *ibuf,unsigned short *obuf); -void GSM_Init(); +void GSM_Init(void); |