softvol, ao_pulse: prefer ao_pulse volume control by default

--softvol is enabled by default. For most audio outputs, this is a good
thing, as they have either their own (bad) soft volume implementation,
or control the system mixer. With ao_pulse, the situation is a bit
different: it supports per-application volume (i.e. volume control is
not really global). More importantly, ao_pulse uses a rather large audio
buffer, and changing the volume with mplayer's volume filter has a large
delay. With the native ao_pulse volume control, it's instant, because
PulseAudio's audio filtering happens at a later stage in its processing
pipeline (inaccessible for mplayer).

This means native volume control should really be allowed for ao_pulse,
while it's the reverse for other audio outputs. Make --softvol a choice
option, and add a new "auto" choice. This is default and will use PA's
volume control with ao_pulse, and mplayer's volume filter otherwise
(i.e. the old softvol behavior).

1 files changed, 2 insertions, 0 deletions

diff --git a/libao2/ao_pulse.c b/libao2/ao_pulse.c
index 0b1f22ff8d..d1282cb2dc 100644
--- a/libao2/ao_pulse.c
+++ b/libao2/ao_pulse.c
@@ -184,6 +184,8 @@ static int init(struct ao *ao, char *params)
     struct priv *priv = talloc_zero(ao, struct priv);
     ao->priv = priv;
 
+    ao->per_application_mixer = true;
+
     if (params) {
         devarg = strdup(params);
         sink = strchr(devarg, ':');