diff options
author | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
---|---|---|
committer | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
commit | e7db4ccf1afbb6653ae1aae44b1c96c724361985 (patch) | |
tree | 9cc7321a75460de67bd0dae4e940b73439a1374b /libao2/ao_null.c | |
parent | 1f34ddefd2546a37c6efe4fcd9ea3f7627af4a5d (diff) | |
download | mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.bz2 mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.xz |
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård
git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2
Diffstat (limited to 'libao2/ao_null.c')
-rw-r--r-- | libao2/ao_null.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/libao2/ao_null.c b/libao2/ao_null.c index 70e3a52b31..7189d98fdf 100644 --- a/libao2/ao_null.c +++ b/libao2/ao_null.c @@ -20,7 +20,7 @@ LIBAO_EXTERN(null) struct timeval last_tv; int buffer; -static void drain(){ +static void drain(void){ struct timeval now_tv; int temp, temp2; @@ -70,24 +70,24 @@ static void uninit(int immed){ } // stop playing and empty buffers (for seeking/pause) -static void reset(){ +static void reset(void){ buffer=0; } // stop playing, keep buffers (for pause) -static void audio_pause() +static void audio_pause(void) { // for now, just call reset(); reset(); } // resume playing, after audio_pause() -static void audio_resume() +static void audio_resume(void) { } // return: how many bytes can be played without blocking -static int get_space(){ +static int get_space(void){ drain(); return ao_data.buffersize - buffer; @@ -106,7 +106,7 @@ static int play(void* data,int len,int flags){ } // return: delay in seconds between first and last sample in buffer -static float get_delay(){ +static float get_delay(void){ drain(); return (float) buffer / (float) ao_data.bps; |