diff options
author | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
---|---|---|
committer | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
commit | e7db4ccf1afbb6653ae1aae44b1c96c724361985 (patch) | |
tree | 9cc7321a75460de67bd0dae4e940b73439a1374b /libao2/ao_alsa.c | |
parent | 1f34ddefd2546a37c6efe4fcd9ea3f7627af4a5d (diff) | |
download | mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.bz2 mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.xz |
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård
git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2
Diffstat (limited to 'libao2/ao_alsa.c')
-rw-r--r-- | libao2/ao_alsa.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/libao2/ao_alsa.c b/libao2/ao_alsa.c index da0017d094..402f89264f 100644 --- a/libao2/ao_alsa.c +++ b/libao2/ao_alsa.c @@ -237,7 +237,7 @@ static void parse_device (char *dest, const char *src, int len) tmp[0] = ':'; } -static void print_help () +static void print_help (void) { mp_msg (MSGT_AO, MSGL_FATAL, "\n-ao alsa commandline help:\n" @@ -725,7 +725,7 @@ static void uninit(int immed) } } -static void audio_pause() +static void audio_pause(void) { int err; @@ -745,7 +745,7 @@ static void audio_pause() } } -static void audio_resume() +static void audio_resume(void) { int err; @@ -766,7 +766,7 @@ static void audio_resume() } /* stop playing and empty buffers (for seeking/pause) */ -static void reset() +static void reset(void) { int err; @@ -1030,7 +1030,7 @@ static int play_mmap(void* data, int len) } /* how many byes are free in the buffer */ -static int get_space() +static int get_space(void) { snd_pcm_status_t *status; int ret; @@ -1100,7 +1100,7 @@ static int get_space() } /* delay in seconds between first and last sample in buffer */ -static float get_delay() +static float get_delay(void) { if (alsa_handler) { |