diff options
author | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
---|---|---|
committer | rathann <rathann@b3059339-0415-0410-9bf9-f77b7e298cf2> | 2006-02-09 14:08:03 +0000 |
commit | e7db4ccf1afbb6653ae1aae44b1c96c724361985 (patch) | |
tree | 9cc7321a75460de67bd0dae4e940b73439a1374b /divx4_vbr.h | |
parent | 1f34ddefd2546a37c6efe4fcd9ea3f7627af4a5d (diff) | |
download | mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.bz2 mpv-e7db4ccf1afbb6653ae1aae44b1c96c724361985.tar.xz |
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård
git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@17567 b3059339-0415-0410-9bf9-f77b7e298cf2
Diffstat (limited to 'divx4_vbr.h')
-rw-r--r-- | divx4_vbr.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/divx4_vbr.h b/divx4_vbr.h index 10a400fcd8..ee26b23a89 100644 --- a/divx4_vbr.h +++ b/divx4_vbr.h @@ -5,13 +5,13 @@ int VbrControl_init_2pass_vbr_encoding(const char* filename, int bitrate, double framerate, int crispness, int quality); int VbrControl_init_2pass_vbr_analysis(const char* filename, int quality); - void VbrControl_update_1pass_vbr(); + void VbrControl_update_1pass_vbr(void); void VbrControl_update_2pass_vbr_encoding(int motion_bits, int texture_bits, int total_bits); void VbrControl_update_2pass_vbr_analysis(int is_key_frame, int motion_bits, int texture_bits, int total_bits, int quant); - int VbrControl_get_quant(); + int VbrControl_get_quant(void); void VbrControl_set_quant(float q); - int VbrControl_get_intra(); - short VbrControl_get_drop(); - void VbrControl_close(); + int VbrControl_get_intra(void); + short VbrControl_get_drop(void); + void VbrControl_close(void); |