path: root/demux/demux_mkv.c
diff options
authorwm4 <wm4@nowhere>2014-07-01 23:10:38 +0200
committerwm4 <wm4@nowhere>2014-07-01 23:11:08 +0200
commit9a210ca2d50e02bf045866bbb2f44a33a3c48cd9 (patch)
tree9f685c66c9d3b2e968416c7f60d30ea56ab1f9bb /demux/demux_mkv.c
parent0208ad4f3b4d2331b8242bb6fb12a9a4475ccae6 (diff)
Audit and replace all ctype.h uses
Something like "char *s = ...; isdigit(s[0]);" triggers undefined behavior, because char can be signed, and thus s[0] can be a negative value. The is*() functions require unsigned char _or_ EOF. EOF is a special value outside of unsigned char range, thus the argument to the is*() functions can't be a char. This undefined behavior can actually trigger crashes if the implementation of these functions e.g. uses lookup tables, which are then indexed with out-of-range values. Replace all <ctype.h> uses with our own custom mp_is*() functions added with misc/ctype.h. As a bonus, these functions are locale-independent. (Although currently, we _require_ C locale for other reasons.)
Diffstat (limited to 'demux/demux_mkv.c')
1 files changed, 0 insertions, 1 deletions
diff --git a/demux/demux_mkv.c b/demux/demux_mkv.c
index e3991372f9..25591cd60a 100644
--- a/demux/demux_mkv.c
+++ b/demux/demux_mkv.c
@@ -23,7 +23,6 @@
#include <stdlib.h>
#include <stdio.h>
-#include <ctype.h>
#include <inttypes.h>
#include <stdbool.h>
#include <assert.h>