core: fix SEEK_FACTOR

Emulate percentage-seeks (SEEK_FACTOR) as normal time-seeks if possible.
This fixes some issues with (let's call it) low quality implementations
of SEEK_FACTOR (e.g. demux_mkv basically interprets this as byte-seek,
and also seeking to 99.9% makes it seek back to the start).

For weird MPEG formats the demuxer level SEEK_FACTOR is still used.
These formats, which can have timestamp resets, are identified by
setting demuxer->ts_resets_possible to true.

Also, have get_current_pos_ratio() follow the same rules, and calculate
the percentage position with the file position if timestamp resets are
possible.

This actually fixes percentage-seeks in .ts files with demux_lavf.c.
This kind of seek is not really used now, but it will be more important
when we add a progress bar.

Note: seeking in chained ogg files is still completely broken. The main
issue is that ffmpeg doesn't provide a sane API for dealing with
timestamp resets, and trying to do byte seeks with ogg confuses demuxer
and decoder (or something like this) and just does random things.
(Tested with two concatenated flac-in-ogg files).

1 files changed, 17 insertions, 4 deletions

diff --git a/demux/demux_lavf.c b/demux/demux_lavf.c
index 3312c27523..50f9f1e8f0 100644
--- a/demux/demux_lavf.c
+++ b/demux/demux_lavf.c
@@ -585,6 +585,8 @@ static demuxer_t *demux_open_lavf(demuxer_t *demuxer)
         demuxer->video->id = -2; // audio-only / sub-only
     }
 
+    demuxer->ts_resets_possible = priv->avif->flags & AVFMT_TS_DISCONT;
+
     // disabled because unreliable per-stream bitrate values returned
     // by libavformat trigger this heuristic incorrectly and break things
 #if 0
@@ -713,16 +715,27 @@ static void demux_seek_lavf(demuxer_t *demuxer, float rel_seek_secs,
         priv->last_pts = 0;
     else if (rel_seek_secs < 0)
         avsflags = AVSEEK_FLAG_BACKWARD;
+
     if (flags & SEEK_FORWARD)
         avsflags = 0;
     else if (flags & SEEK_BACKWARD)
         avsflags = AVSEEK_FLAG_BACKWARD;
+
     if (flags & SEEK_FACTOR) {
-        if (priv->avfc->duration == 0 || priv->avfc->duration == AV_NOPTS_VALUE)
-            return;
-        priv->last_pts += rel_seek_secs * priv->avfc->duration;
-    } else
+        if (demuxer->movi_end > 0 && demuxer->ts_resets_possible &&
+            !(priv->avif->flags & AVFMT_NO_BYTE_SEEK))
+        {
+            avsflags |= AVSEEK_FLAG_BYTE;
+            priv->last_pts = (demuxer->movi_end - demuxer->movi_start) *
+                             rel_seek_secs;
+        } else if (priv->avfc->duration != 0 &&
+                   priv->avfc->duration != AV_NOPTS_VALUE)
+        {
+            priv->last_pts = rel_seek_secs * priv->avfc->duration;
+        }
+    } else {
         priv->last_pts += rel_seek_secs * AV_TIME_BASE;
+    }
 
     if (!priv->avfc->iformat->read_seek2) {
         // Normal seeking.