summaryrefslogtreecommitdiffstats
path: root/common/msg.c
diff options
context:
space:
mode:
authorwm4 <wm4@nowhere>2015-04-23 21:08:19 +0200
committerwm4 <wm4@nowhere>2015-04-23 21:08:19 +0200
commit91f6f2bf11af3705e55f16fef6379f4b2092a19d (patch)
tree9afcd70853587d1c7d0bc1fbd094ae8baf7fb2aa /common/msg.c
parentb98949c72cc5fdf6e4c19aa06148f888961ad36b (diff)
downloadmpv-91f6f2bf11af3705e55f16fef6379f4b2092a19d.tar.bz2
mpv-91f6f2bf11af3705e55f16fef6379f4b2092a19d.tar.xz
options: remove unneeded hack from command line parser
This was traditionally needed to silence terminal output from errors during command line parsing preparsing. Preparsing is done so that options controlling the terminal and config files are parsed and applied first, with a second command line parsing pass applying all other options, _and_ printing error messages for the preparsed ones. But the hack silencing log output during the preparse pass is actually not needed anymore, since the terminal is enabled only after preparsing is finished. update_logging() in main.c does this. So as long as update_logging() is called before m_config_preparse_command_line(), this will work.
Diffstat (limited to 'common/msg.c')
-rw-r--r--common/msg.c11
1 files changed, 1 insertions, 10 deletions
diff --git a/common/msg.c b/common/msg.c
index 34ed677a22..3a441d0bcf 100644
--- a/common/msg.c
+++ b/common/msg.c
@@ -61,8 +61,6 @@ struct mp_log_root {
int num_buffers;
FILE *log_file;
FILE *stats_file;
- // --- semi-atomic access
- bool mute;
// --- must be accessed atomically
/* This is incremented every time the msglevels must be reloaded.
* (This is perhaps better than maintaining a globally accessible and
@@ -133,7 +131,7 @@ static void update_loglevel(struct mp_log *log)
bool mp_msg_test(struct mp_log *log, int lev)
{
struct mp_log_root *root = log->root;
- if (!root || root->mute)
+ if (!root)
return false;
if (atomic_load_explicit(&log->reload_counter, memory_order_relaxed) !=
atomic_load_explicit(&root->reload_counter, memory_order_relaxed))
@@ -486,13 +484,6 @@ void mp_msg_update_msglevels(struct mpv_global *global)
pthread_mutex_unlock(&mp_msg_lock);
}
-void mp_msg_mute(struct mpv_global *global, bool mute)
-{
- struct mp_log_root *root = global->log->root;
-
- root->mute = mute;
-}
-
void mp_msg_force_stderr(struct mpv_global *global, bool force_stderr)
{
struct mp_log_root *root = global->log->root;