diff options
| author | wm4 <wm4@nowhere> | 2012-07-29 18:00:41 +0200 |
|---|---|---|
| committer | wm4 <wm4@nowhere> | 2012-07-30 01:38:53 +0200 |
| commit | 897d1c01bca01bf874d4cd45a9bb4fc9b2b2806f (patch) | |
| tree | 2c1b3588387aa13d6d8ff1da5c5fdbec37f76f6f /cfg-mplayer.h | |
| parent | 35291b8ad9590f000f89ec37dc85aa6f5e9741a7 (diff) | |
| download | mpv-897d1c01bca01bf874d4cd45a9bb4fc9b2b2806f.tar.bz2 mpv-897d1c01bca01bf874d4cd45a9bb4fc9b2b2806f.tar.xz | |
mplayer: remove crash handler stuff
mplayer tries to catch all signals by default, and displays a "nice"
crash message if a signal is caught. This is mostly useless for
diagnosing problems, and it's extremely fragile. It's likely to cause
more harm than it possibly solves.
Also remove the current_module variable, which was supposed to give a
hint which submodule was being run. This was far from accurate or
useful.
mplayer also caught SIG_CHILD, and tried to wait for any children. This
potentially gets rid of zombies, but I'm not sure which ones. The only
places that fork(), cache2.c and unrar_exec.c, seem to wait for their
child processes properly. Just get rid of it.
Note that we don't even catch SIGTERM. Maybe this will have to be added
back in order to re-enable screensavers and such when the user
terminates mplayer with ^C on the terminal.
Diffstat (limited to 'cfg-mplayer.h')
| -rw-r--r-- | cfg-mplayer.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/cfg-mplayer.h b/cfg-mplayer.h index b014e64893..32a513c437 100644 --- a/cfg-mplayer.h +++ b/cfg-mplayer.h @@ -821,10 +821,6 @@ const m_option_t mplayer_opts[]={ {"nouse-filedir-conf", &use_filedir_conf, CONF_TYPE_FLAG, CONF_GLOBAL, 1, 0, NULL}, {"use-filename-title", &use_filename_title, CONF_TYPE_FLAG, CONF_GLOBAL, 0, 1, NULL}, {"nouse-filename-title", &use_filename_title, CONF_TYPE_FLAG, CONF_GLOBAL, 1, 0, NULL}, -#ifdef CONFIG_CRASH_DEBUG - {"crash-debug", &crash_debug, CONF_TYPE_FLAG, CONF_GLOBAL, 0, 1, NULL}, - {"nocrash-debug", &crash_debug, CONF_TYPE_FLAG, CONF_GLOBAL, 1, 0, NULL}, -#endif OPT_INTRANGE("osdlevel", osd_level, 0, 0, 3), OPT_INTRANGE("osd-duration", osd_duration, 0, 0, 3600000), OPT_INTRANGE("osd-fractions", osd_fractions, 0, 0, 2), |