diff options
| author | wm4 <wm4@nowhere> | 2012-08-12 15:30:21 +0200 |
|---|---|---|
| committer | wm4 <wm4@nowhere> | 2012-08-16 17:16:33 +0200 |
| commit | aebfbbf2bdda8e18beef90c16da97bd335f7d3b0 (patch) | |
| tree | a7362bf3ef6f2d80a47b2e539a2ea4efe5e2e079 /cfg-mplayer.h | |
| parent | c6b03ffef6250096373c4a81a489dae9fbff9087 (diff) | |
| download | mpv-aebfbbf2bdda8e18beef90c16da97bd335f7d3b0.tar.bz2 mpv-aebfbbf2bdda8e18beef90c16da97bd335f7d3b0.tar.xz | |
Remove win32/qt/xanim/real binary codecs loading
Remove the win32 loader - the win32 emulation layer, as well as the
code for using DirectShow/DMO/VFW codecs. Remove loading of xanim,
QuickTime, and RealMedia codecs.
The win32 emulation layer is based on a very old version of wine.
Apparently, wine code was copied and hacked until it was somehow able
to load a limited collection of binary codecs. It poked around in the
code segment of some known binary codecs to disable unsupported win32
API calls to make them work. Example from module.c:
for (i=0;i<5;i++) RVA(0x19e842)[i]=0x90; // make_new_region ?
for (i=0;i<28;i++) RVA(0x19e86d)[i]=0x90; // call__call_CreateCompatibleDC ?
for (i=0;i<5;i++) RVA(0x19e898)[i]=0x90; // jmp_to_call_loadbitmap ?
for (i=0;i<9;i++) RVA(0x19e8ac)[i]=0x90; // call__calls_OLE_shit ?
for (i=0;i<106;i++) RVA(0x261b10)[i]=0x90; // disable threads
Just to show how utterly insane this code is. You wouldn't want even
your worst enemy to have to maintain this. In fact, it seems nobody
made major changes to this code ever since it was committed.
Most formats can be decoded by libavcodecs these days, and the loader
couldn't be used on 64 bit platforms anyway. The same is (probably)
true for the other binary codecs.
General note about how support for win32 codecs could be added back:
It's not possible to replace the win32 loader code by using wine as
library, because modern wine can not be linked with native Linux
programs for certain reasons. It would be possible to to move DirectShow
video decoding into a separate process linked with wine, like the
CoreAVC-for-Linux patches do. There is also the mplayer-ww fork, which
uses the dshownative library to use DirectShow codecs on Windows.
Diffstat (limited to 'cfg-mplayer.h')
| -rw-r--r-- | cfg-mplayer.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/cfg-mplayer.h b/cfg-mplayer.h index 83fe9e3589..da39b06c65 100644 --- a/cfg-mplayer.h +++ b/cfg-mplayer.h @@ -363,7 +363,6 @@ const m_option_t common_opts[] = { #ifdef CONFIG_PRIORITY {"priority", &proc_priority, CONF_TYPE_STRING, 0, 0, 0, NULL}, #endif - {"codecpath", &codec_path, CONF_TYPE_STRING, 0, 0, 0, NULL}, OPT_CHOICE("noconfig", noconfig, CONF_GLOBAL | CONF_NOCFG | CONF_PRE_PARSE, ({"off", 0}, {"user", 1}, {"system", 2}, {"all", 3})), |