summaryrefslogtreecommitdiffstats
path: root/audio
diff options
context:
space:
mode:
authorwm4 <wm4@nowhere>2017-06-27 14:22:28 +0200
committerwm4 <wm4@nowhere>2017-06-29 10:31:13 +0200
commitcd25d98bfa38c87bd857264e876cd8be42eb3678 (patch)
treef721ae2930ac3ce823326592f986f4f4c20654e6 /audio
parent7eca787571aab982acaadee79abb0f40f9f14b6a (diff)
downloadmpv-cd25d98bfa38c87bd857264e876cd8be42eb3678.tar.bz2
mpv-cd25d98bfa38c87bd857264e876cd8be42eb3678.tar.xz
Avoid calling close(-1)
While this is perfectly OK on Unix, it causes annoying valgrind warnings, and might be otherwise confusing to others. On Windows, the runtime can actually abort the process if this is called. push.c part taken from a patch by Pedro Pombeiro.
Diffstat (limited to 'audio')
-rw-r--r--audio/out/push.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/audio/out/push.c b/audio/out/push.c
index c271fc0cdc..c4083923fd 100644
--- a/audio/out/push.c
+++ b/audio/out/push.c
@@ -423,8 +423,11 @@ static void destroy_no_thread(struct ao *ao)
ao->driver->uninit(ao);
- for (int n = 0; n < 2; n++)
- close(p->wakeup_pipe[n]);
+ for (int n = 0; n < 2; n++) {
+ int h = p->wakeup_pipe[n];
+ if (h >= 0)
+ close(h);
+ }
pthread_cond_destroy(&p->wakeup);
pthread_mutex_destroy(&p->lock);