diff options
author | wm4 <wm4@nowhere> | 2014-04-15 22:50:16 +0200 |
---|---|---|
committer | wm4 <wm4@nowhere> | 2014-04-15 22:50:16 +0200 |
commit | 5aeec9aa70f47a88aeb20057169d54c54e87d017 (patch) | |
tree | a2fe13a577030e60d0773e493517ef9fb7c74460 /audio/out | |
parent | ad75b8e339e3a8a1aae3564695a572836228cdc5 (diff) | |
download | mpv-5aeec9aa70f47a88aeb20057169d54c54e87d017.tar.bz2 mpv-5aeec9aa70f47a88aeb20057169d54c54e87d017.tar.xz |
audio: wake up the core when audio buffer is running low (2)
Same change as in e2184fcb, but this time for pull based AOs. This is
slightly controversial, because it will make a fast syscall from e.g.
ao_jack. And according to JackAudio developers, syscalls are evil and
will destroy realtime operation. But I don't think this is an issue at
all.
Still avoid locking a mutex. I'm not sure what jackaudio does in the
worst case - but if they set the jackaudio thread (and only this thread)
to realtime, we might run into deadlock situations due to priority
inversion and such. I'm not quite sure whether this can happen, but I'll
readily follow the cargo cult if it makes hack happy.
Diffstat (limited to 'audio/out')
-rw-r--r-- | audio/out/pull.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/audio/out/pull.c b/audio/out/pull.c index 01e581925d..4b0dc6e890 100644 --- a/audio/out/pull.c +++ b/audio/out/pull.c @@ -26,6 +26,8 @@ #include "common/msg.h" #include "common/common.h" +#include "input/input.h" + #include "osdep/timer.h" #include "osdep/threads.h" #include "compat/atomics.h" @@ -110,8 +112,8 @@ int ao_read_data(struct ao *ao, void **data, int samples, int64_t out_time_us) // Since the writer will write the first plane last, its buffered amount // of data is the minimum amount across all planes. - int bytes = mp_ring_buffered(p->buffers[0]); - bytes = MPMIN(bytes, full_bytes); + int buffered_bytes = mp_ring_buffered(p->buffers[0]); + int bytes = MPMIN(buffered_bytes, full_bytes); if (bytes > 0) p->end_time_us = out_time_us; @@ -128,6 +130,11 @@ int ao_read_data(struct ao *ao, void **data, int samples, int64_t out_time_us) if (silence) af_fill_silence((char *)data[n] + bytes, silence, ao->format); } + + // Half of the buffer played -> request more. + if (buffered_bytes - bytes <= mp_ring_size(p->buffers[0]) / 2) + mp_input_wakeup_nolock(ao->input_ctx); + return bytes / ao->sstride; } |