audio: drop swapped-endian audio formats

Until now, the audio chain could handle both little endian and big
endian formats. This actually doesn't make much sense, since the audio
API and the HW will most likely prefer native formats. Or at the very
least, it should be trivial for audio drivers to do the byte swapping
themselves.

From now on, the audio chain contains native-endian formats only. All
AOs and some filters are adjusted. af_convertsignendian.c is now wrongly
named, but the filter name is adjusted. In some cases, the audio
infrastructure was reused on the demuxer side, but that is relatively
easy to rectify.

This is a quite intrusive and radical change. It's possible that it will
break some things (especially if they're obscure or not Linux), so watch
out for regressions. It's probably still better to do it the bulldozer
way, since slow transition and researching foreign platforms would take
a lot of time and effort.

1 files changed, 14 insertions, 7 deletions

diff --git a/audio/out/ao_pcm.c b/audio/out/ao_pcm.c
index 3c1f46409a..eb089c6c42 100644
--- a/audio/out/ao_pcm.c
+++ b/audio/out/ao_pcm.c
@@ -35,6 +35,7 @@
 #include "ao.h"
 #include "internal.h"
 #include "common/msg.h"
+#include "osdep/endian.h"
 
 #ifdef __MINGW32__
 // for GetFileType to detect pipes
@@ -72,8 +73,7 @@ static void fput32le(uint32_t val, FILE *fp)
 static void write_wave_header(struct ao *ao, FILE *fp, uint64_t data_length)
 {
     bool use_waveex = true;
-    uint16_t fmt = ao->format == AF_FORMAT_FLOAT_LE ?
-        WAV_ID_FLOAT_PCM : WAV_ID_PCM;
+    uint16_t fmt = ao->format == AF_FORMAT_FLOAT ? WAV_ID_FLOAT_PCM : WAV_ID_PCM;
     uint32_t fmt_chunk_size = use_waveex ? 40 : 16;
     int bits = af_fmt2bits(ao->format);
 
@@ -124,16 +124,23 @@ static int init(struct ao *ao)
     if (priv->waveheader) {
         // WAV files must have one of the following formats
 
+        // And they don't work in big endian; fixing it would be simple, but
+        // nobody cares.
+        if (BYTE_ORDER == BIG_ENDIAN) {
+            MP_FATAL(ao, "Not supported on big endian.\n");
+            return -1;
+        }
+
         switch (ao->format) {
         case AF_FORMAT_U8:
-        case AF_FORMAT_S16_LE:
-        case AF_FORMAT_S24_LE:
-        case AF_FORMAT_S32_LE:
-        case AF_FORMAT_FLOAT_LE:
+        case AF_FORMAT_S16:
+        case AF_FORMAT_S24:
+        case AF_FORMAT_S32:
+        case AF_FORMAT_FLOAT:
         case AF_FORMAT_AC3:
              break;
         default:
-            ao->format = AF_FORMAT_S16_LE;
+            ao->format = AF_FORMAT_S16;
             break;
         }
     }