diff options
| author | wm4 <wm4@nowhere> | 2020-05-31 15:00:35 +0200 |
|---|---|---|
| committer | wm4 <wm4@nowhere> | 2020-06-01 01:08:16 +0200 |
| commit | d27ad9654218463694093697e3d09f8983b4ccf3 (patch) | |
| tree | 54d889bbed1b32b2a702fee6825c66ff6fb60c33 /audio/out/ao_coreaudio.c | |
| parent | d448dd5bf26408ccced1bd6df8f9eaf62a370c8e (diff) | |
| download | mpv-d27ad9654218463694093697e3d09f8983b4ccf3.tar.bz2 mpv-d27ad9654218463694093697e3d09f8983b4ccf3.tar.xz | |
audio: redo internal AO API
This affects "pull" AOs only: ao_alsa, ao_pulse, ao_openal, ao_pcm,
ao_lavc. There are changes to the other AOs too, but that's only about
renaming ao_driver.resume to ao_driver.start.
ao_openal is broken because I didn't manage to fix it, so it exits with
an error message. If you want it, why don't _you_ put effort into it? I
see no reason to waste my own precious lifetime over this (I realize the
irony).
ao_alsa loses the poll() mechanism, but it was mostly broken and didn't
really do what it was supposed to. There doesn't seem to be anything in
the ALSA API to watch the playback status without polling (unless you
want to use raw UNIX signals).
No idea if ao_pulse is correct, or whether it's subtly broken now. There
is no documentation, so I can't tell what is correct, without reverse
engineering the whole project. I recommend using ALSA.
This was supposed to be just a simple fix, but somehow it expanded scope
like a train wreck. Very high chance of regressions, but probably only
for the AOs listed above. The rest you can figure out from reading the
diff.
Diffstat (limited to 'audio/out/ao_coreaudio.c')
| -rw-r--r-- | audio/out/ao_coreaudio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/audio/out/ao_coreaudio.c b/audio/out/ao_coreaudio.c index 533d102d32..99007ef018 100644 --- a/audio/out/ao_coreaudio.c +++ b/audio/out/ao_coreaudio.c @@ -417,7 +417,7 @@ const struct ao_driver audio_out_coreaudio = { .init = init, .control = control, .reset = stop, - .resume = start, + .start = start, .hotplug_init = hotplug_init, .hotplug_uninit = hotplug_uninit, .list_devs = ca_get_device_list, |