summaryrefslogtreecommitdiffstats
path: root/DOCS
diff options
context:
space:
mode:
authorwm4 <wm4@nowhere>2020-02-15 14:07:46 +0100
committerwm4 <wm4@nowhere>2020-02-15 14:07:46 +0100
commit121bc6ad62a75eb4a3c9cbd2d4f96fcd18593ac9 (patch)
tree1c5dabbb2aa255dc1969b99cd47ce4a2ac1dde9b /DOCS
parent64a03b03eacaca7a5b9c2e7323d96811ecad83e0 (diff)
downloadmpv-121bc6ad62a75eb4a3c9cbd2d4f96fcd18593ac9.tar.bz2
mpv-121bc6ad62a75eb4a3c9cbd2d4f96fcd18593ac9.tar.xz
demux_timeline: fix another cursed memory management issue
The timeline stuff has messed up memory management because there are no clear ownership rules between a some demuxer instances (master or demux_timeline) and the timeline object itself. This is another subtle problem that happened: apparently, demux_timeline.open is supposed to take over ownership of timeline, but only on success. If it fails, it's not supposed to free it. It didn't follow this, which lead to a double-free if demux_timeline.open failed. The failure path in demux.c calls both timeline_destroy() and demux_timeline.close on failure.
Diffstat (limited to 'DOCS')
0 files changed, 0 insertions, 0 deletions