options: take care of propertly updating options on runtime changes

All option write accesses are now put through the property interface,
which means runtime option value verification and runtime updates are
applied. This is done even for command line arguments and config files.

This has many subtle and not-so-subtle consequences. The potential for
unintended and intended subtle or not-subtle behavior changes is very
large.

Architecturally, this is us literally jumping through hoops. It really
should work the other way around, with options being able to have
callbacks for value verification and applying runtime updates. But this
would require rewriting the entirety of command.c. This change is more
practical, and if anything will at least allow incremental changes.

Some options are too incompatible for this to work - these are excluded
with an explicit blacklist.

This change fixes many issues caused by the mismatch between properties
and options. For example, this fixes #3281.

1 files changed, 8 insertions, 0 deletions

diff --git a/DOCS/man/input.rst b/DOCS/man/input.rst
index cc81e6a125..3588d66599 100644
--- a/DOCS/man/input.rst
+++ b/DOCS/man/input.rst
@@ -2066,11 +2066,15 @@ caveats with some properties (due to historical reasons):
     allows setting any track ID, and which tracks to enable is chosen at
     loading time.)
 
+    Option changes at runtime are affected by this as well.
+
 ``deinterlace``
     While video is active, this behaves differently from the option. It will
     never return the ``auto`` value (but the state as observed by the video
     chain). You cannot set ``auto`` either.
 
+    Option changes at runtime are affected by this as well.
+
 ``video-aspect``
     While video is active, always returns the effective aspect ratio.
 
@@ -2089,11 +2093,15 @@ caveats with some properties (due to historical reasons):
     same way. Also, there are no ``vf-add`` etc. properties, but you can use
     the ``vf``/``af`` group of commands to achieve the same.
 
+    Option changes at runtime are affected by this as well.
+
 ``chapter``
     While playback is *not* active, the property behaves like the option, and
     you can set a chapter range. While playback is active, you can set only
     the current chapter (to which the player will seek immediately).
 
+    Option changes at runtime are affected by this as well.
+
 ``volume``
     When set as option, the maximum (set by ``--volume-max``) is not checked,
     while when set as property, the maximum is enforced.