diff options
| author | wm4 <wm4@nowhere> | 2019-10-25 00:25:05 +0200 |
|---|---|---|
| committer | wm4 <wm4@nowhere> | 2019-10-25 00:25:05 +0200 |
| commit | 77f309c94ff17f5627290a7a5a4477db714ecd1e (patch) | |
| tree | 196c04befa3756aa12906634be6fa2c2e136a205 /DOCS/interface-changes.rst | |
| parent | b0827b4dc4417de36e596c5adde9cd28605fdf81 (diff) | |
| download | mpv-77f309c94ff17f5627290a7a5a4477db714ecd1e.tar.bz2 mpv-77f309c94ff17f5627290a7a5a4477db714ecd1e.tar.xz | |
vo_gpu, options: don't return NaN through API
Internally, vo_gpu uses NaN for some options to indicate a default value
that is different depending on the context (e.g. different scalers).
There are 2 problems with this:
1. you couldn't reset the options to their defaults
2. NaN is a damn mess and shouldn't be part of the API
The option parser already rejected NaN explicitly, which is why 1.
didn't work. Regarding 2., JSON might be a good example, and actually
caused a bug report.
Fix this by mapping NaN to the special value "default". I think I'd
prefer other mechanisms (maybe just having every scaler expose separate
options?), but for now this will do. See you in a future commit, which
painfully deprecates this and replaces it with something else.
I refrained from using "no" (my favorite magic value for "unset" etc.)
because then I'd have e.g. make --no-scale-param1 work, which in
addition to a lot of effort looks dumb and nobody will use it.
Here's also an apology for the shitty added test script.
Fixes: #6691
Diffstat (limited to 'DOCS/interface-changes.rst')
| -rw-r--r-- | DOCS/interface-changes.rst | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/DOCS/interface-changes.rst b/DOCS/interface-changes.rst index 038b87b6c1..59891272da 100644 --- a/DOCS/interface-changes.rst +++ b/DOCS/interface-changes.rst @@ -191,6 +191,9 @@ Interface changes internal counter that remembered the current position. - remove deprecated ao/vo auto profiles. Consider using scripts like auto-profiles.lua instead. + - --[c]scale-[w]param[1|2] and --tone-mapping-param now accept "default", + and if set to that value, reading them as property will also return + "default", instead of float nan as in previous versions --- mpv 0.28.0 --- - rename --hwdec=mediacodec option to mediacodec-copy, to reflect conventions followed by other hardware video decoding APIs |