diff options
authorwm4 <wm4@nowhere>2013-10-28 23:43:07 +0100
committerwm4 <wm4@nowhere>2013-11-02 19:05:10 +0100
commit10c3b71720d413b439585fd604d7815102ff505b (patch)
parent0ba37607451da7b85b295e68c7824bb73b631b48 (diff)
gl_x11: change error message when GL3 context creation fails
On systems that provide legacy OpenGL (up to 2.1), but not GL3 and later, creating a GL3 context will fail. We then revert to legacy GL. Apparently the error message printed when the GL3 context creation fails is confusing. We could just silence it, but there's still a X error ("X11 error: GLXBadFBConfig"), which would be quite hard to filter out. For one, it would require messing with the X11 error handler, which doesn't even carry a context pointer (for application private data), so we don't even want to touch it. Instead, change the error message to inform the user what's actually happening: a fallback to an older version of OpenGL.
1 files changed, 1 insertions, 1 deletions
diff --git a/video/out/gl_x11.c b/video/out/gl_x11.c
index 99239d0b30..2ed0bfbef5 100644
--- a/video/out/gl_x11.c
+++ b/video/out/gl_x11.c
@@ -123,7 +123,7 @@ static bool create_context_x11_gl3(struct MPGLContext *ctx, bool debug)
glx_ctx->fbc, 0, True,
if (!context) {
- MP_FATAL(vo, "Could not create GLX context!\n");
+ MP_ERR(vo, "Could not create GL3 context. Retrying with legacy context.\n");
return false;