diff options
authorwm4 <wm4@nowhere>2014-11-01 01:06:22 +0100
committerwm4 <wm4@nowhere>2014-11-01 01:06:22 +0100
commit0e97808fc5ecfa252584d0d52abc69aab0bad4e5 (patch)
parentb66669ef2cb433d4514175e2b97f926cfdc8bcc6 (diff)
player: show AV-desync message in all framedrop modes
This was shown only if decoder-framedropping was enabled, and only if at least 50 frames were dropped by it. Since drop_frame_cnt used to mean "number of late frames", this code made sense, but this is not the case anymore: drop_frame_cnt can be even 0, all while video gets hopelessly behind audio. One problem with this is that short desync spikes (which usually can probably dealt with) will also cause this message to be shown. If it gets triggered too often, the code will need to be adjusted.
1 files changed, 1 insertions, 2 deletions
diff --git a/player/video.c b/player/video.c
index 7e4de2482f..092975d776 100644
--- a/player/video.c
+++ b/player/video.c
@@ -682,8 +682,7 @@ static void update_avsync_after_frame(struct MPContext *mpctx)
mpctx->time_frame * mpctx->opts->playback_speed;
if (a_pos == MP_NOPTS_VALUE || mpctx->video_pts == MP_NOPTS_VALUE)
mpctx->last_av_difference = MP_NOPTS_VALUE;
- if (mpctx->last_av_difference > 0.5 && mpctx->drop_frame_cnt > 50
- && !mpctx->drop_message_shown) {
+ if (mpctx->last_av_difference > 0.5 && !mpctx->drop_message_shown) {
MP_WARN(mpctx, "%s", av_desync_help_text);
mpctx->drop_message_shown = true;