summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrobin007bond <robin007bond@users.noreply.github.com>2015-04-13 14:51:03 +0200
committerwm4 <wm4@nowhere>2015-04-13 15:11:09 +0200
commit3b2cc79d2f42eefebf4390ccf722e1bb02d6f734 (patch)
tree84cc721d5cf2fad3dd0a17d425c1920e106ef1ea
parent5b1c3e4b500c69c5c07a6e6b2b65902ea4ce56a4 (diff)
downloadmpv-3b2cc79d2f42eefebf4390ccf722e1bb02d6f734.tar.bz2
mpv-3b2cc79d2f42eefebf4390ccf722e1bb02d6f734.tar.xz
DOCS/contribute.md: Add guideline for pull requests
This commit is to prevent changes being merged into upstream, without being known if it is tested or not. Signed-off-by: wm4 <wm4@nowhere>
-rw-r--r--DOCS/contribute.md3
1 files changed, 3 insertions, 0 deletions
diff --git a/DOCS/contribute.md b/DOCS/contribute.md
index 224c52494c..11b5e33d50 100644
--- a/DOCS/contribute.md
+++ b/DOCS/contribute.md
@@ -14,6 +14,9 @@ Sending patches
``git format-patch``. diffs posted as pastebins (especially if the http link
returns HTML) just cause extra work for everyone, because they lack commit
message and authorship information.
+- When creating pull requests, be sure to test your changes. If you didn't, please
+ say so in the pull request message.
+
- Write informative commit messages. Use present tense to describe the
situation with the patch applied, and past tense for the situation before
the change.