diff options
| author | Dudemanguy <random342@airmail.cc> | 2021-10-26 13:21:08 -0500 |
|---|---|---|
| committer | Dudemanguy <random342@airmail.cc> | 2021-10-26 13:21:08 -0500 |
| commit | e4ee0c6ebcc438741b32f6ecb0795158055f35f3 (patch) | |
| tree | e80aa1644926c9b730de18593b689122124959dc | |
| parent | e6ab676d2023e746b439c21e1fdb4c3da4856d00 (diff) | |
| download | mpv-e4ee0c6ebcc438741b32f6ecb0795158055f35f3.tar.bz2 mpv-e4ee0c6ebcc438741b32f6ecb0795158055f35f3.tar.xz | |
wayland: remove incorrect keepaspect check
In the reconfig event, the keepaspect option was checked before setting
the window_size geometry to the new params obtained from the vo. This is
incorrect. If a user disabled keepaspect on wayland, the video's size
would not change on a reconfigure event (i.e. loading a new video in the
playlist with a different size). No other windowing backend (x11, win32,
etc.) behaves like this or uses keepaspect in its code like wayland did
in this case. Clearly, this is not correct. Such functionality should be
handled by a separate option entirely. Just remove this if statement.
| -rw-r--r-- | video/out/wayland_common.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/video/out/wayland_common.c b/video/out/wayland_common.c index 1fd5ad85df..6810069d4f 100644 --- a/video/out/wayland_common.c +++ b/video/out/wayland_common.c @@ -1793,8 +1793,7 @@ int vo_wayland_reconfig(struct vo *vo) set_geometry(wl); - if (wl->vo_opts->keepaspect) - wl->window_size = wl->vdparams; + wl->window_size = wl->vdparams; if (!wl->vo_opts->fullscreen && !wl->vo_opts->window_maximized) wl->geometry = wl->window_size; |