summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorwm4 <wm4@nowhere>2018-03-01 13:41:27 +0100
committerJan Ekström <jeebjp@gmail.com>2018-03-03 02:38:01 +0200
commit9daa842b5fa8966e4003a29c740ec94340021d17 (patch)
tree6028a533961752f5dfb04d8b4bfc82d98b5f1f22
parente0c67977b2d8cb7e90c2cb6522594a9bdd566ccf (diff)
downloadmpv-9daa842b5fa8966e4003a29c740ec94340021d17.tar.bz2
mpv-9daa842b5fa8966e4003a29c740ec94340021d17.tar.xz
player: add warning comment about ignoring ABI safety
At least ffmpeg_garbage() uses sizeof(AVFrameSideData), which is not included in the ABI, but there's no ABI-safe alternative either.
-rw-r--r--player/main.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/player/main.c b/player/main.c
index 243eae605f..5a3fe4c1b7 100644
--- a/player/main.c
+++ b/player/main.c
@@ -426,6 +426,9 @@ int mp_initialize(struct MPContext *mpctx, char **options)
if (!print_libav_versions(mp_null_log, 0)) {
// Using mismatched libraries can be legitimate, but even then it's
// a bad idea. We don't acknowledge its usefulness and stability.
+ // Distro maintainers who patch this out should be aware that mpv
+ // intentionally ignores ABI in some places where it's not possible to
+ // get by without violating it.
print_libav_versions(mpctx->log, MSGL_FATAL);
MP_FATAL(mpctx, "\nmpv was compiled against a different version of "
"FFmpeg/Libav than the shared\nlibrary it is linked against. "