From 4c3ace7cdcc740652331dbd57cc500b4ad50be81 Mon Sep 17 00:00:00 2001 From: Oleg Oshmyan Date: Sat, 25 Sep 2021 16:45:32 +0300 Subject: fontselect: don't leak substitution fullname array if it's empty Discovered by OSS-Fuzz. This is a longstanding bug (since 0.13.0 released in 2015, when the new fontselect was first introduced), but it should be rare: it only manifests when Fontconfig has no substitutions configured (which is unusual) or when font name strdups fail. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=39257. --- libass/ass_fontselect.c | 1 + 1 file changed, 1 insertion(+) (limited to 'libass') diff --git a/libass/ass_fontselect.c b/libass/ass_fontselect.c index b47c4bc..02b8d9c 100644 --- a/libass/ass_fontselect.c +++ b/libass/ass_fontselect.c @@ -856,6 +856,7 @@ static char *select_font(ASS_FontSelector *priv, } if (!meta.n_fullname) { + free(meta.fullnames); meta = default_meta; } -- cgit v1.2.3