From 5f57443f1784434fe8961275da08be6d6febc688 Mon Sep 17 00:00:00 2001 From: Oneric Date: Thu, 22 Sep 2022 01:23:05 +0200 Subject: parse: remove useless branch If state.effect_timing is zero adding it does nothing. Also checking for zero and branching is likely at least as costly as adding zero. --- libass/ass_parse.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libass/ass_parse.c b/libass/ass_parse.c index 0be9d78..0b30b68 100644 --- a/libass/ass_parse.c +++ b/libass/ass_parse.c @@ -795,8 +795,7 @@ char *parse_tags(ASS_Renderer *render_priv, char *p, char *end, double pwr, if (nargs) val = argtod(*args); render_priv->state.effect_type = EF_KARAOKE_KF; - if (render_priv->state.effect_timing) - render_priv->state.effect_skip_timing += + render_priv->state.effect_skip_timing += render_priv->state.effect_timing; render_priv->state.effect_timing = dtoi32(val * 10); } else if (tag("ko")) { @@ -804,8 +803,7 @@ char *parse_tags(ASS_Renderer *render_priv, char *p, char *end, double pwr, if (nargs) val = argtod(*args); render_priv->state.effect_type = EF_KARAOKE_KO; - if (render_priv->state.effect_timing) - render_priv->state.effect_skip_timing += + render_priv->state.effect_skip_timing += render_priv->state.effect_timing; render_priv->state.effect_timing = dtoi32(val * 10); } else if (tag("k")) { @@ -813,8 +811,7 @@ char *parse_tags(ASS_Renderer *render_priv, char *p, char *end, double pwr, if (nargs) val = argtod(*args); render_priv->state.effect_type = EF_KARAOKE; - if (render_priv->state.effect_timing) - render_priv->state.effect_skip_timing += + render_priv->state.effect_skip_timing += render_priv->state.effect_timing; render_priv->state.effect_timing = dtoi32(val * 10); } else if (tag("shad")) { -- cgit v1.2.3