From 52ec0bab2f2b2027daa0415124d08e9898c5529a Mon Sep 17 00:00:00 2001 From: wm4 Date: Sun, 16 Nov 2014 17:23:39 +0100 Subject: Check the overflow check for overflows Seriously... Checking for negative values might not be needed, but do it anyway. --- libass/ass_bitmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libass/ass_bitmap.c b/libass/ass_bitmap.c index 2c523b4..97e93a0 100644 --- a/libass/ass_bitmap.c +++ b/libass/ass_bitmap.c @@ -302,7 +302,7 @@ Bitmap *outline_to_bitmap(ASS_Renderer *render_priv, int w = x_max - x_min; int h = y_max - y_min; - if (w * h > 8000000) { + if (w < 0 || h < 0 || w > 8000000 / FFMAX(h, 1)) { ass_msg(render_priv->library, MSGL_WARN, "Glyph bounding box too large: %dx%dpx", w, h); return NULL; -- cgit v1.2.3