summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--libass/ass_fontselect.c4
-rw-r--r--libass/ass_types.h1
2 files changed, 5 insertions, 0 deletions
diff --git a/libass/ass_fontselect.c b/libass/ass_fontselect.c
index ed4b35f..cf1c088 100644
--- a/libass/ass_fontselect.c
+++ b/libass/ass_fontselect.c
@@ -505,6 +505,8 @@ static char *select_font(ASS_FontSelector *priv, ASS_Library *library,
ASS_FontProvider *provider = font_infos[idx].provider;
stream->func = provider->funcs.get_data;
stream->priv = font_infos[idx].priv;
+ // FIXME: we should define a default family name in some way,
+ // possibly the first (or last) English name
return strdup(font_infos[idx].families[0]);
} else
return strdup(font_infos[idx].path);
@@ -552,6 +554,8 @@ char *ass_font_select(ASS_FontSelector *priv, ASS_Library *library,
res, *index);
}
+ // FIXME: not sure if that is needed, we cannot reach this path at the
+ // moment, either select_font returns or a font or the default one is used
if (!res) {
res = select_font(priv, library, "Arial", bold, italic,
index, uid, data, code);
diff --git a/libass/ass_types.h b/libass/ass_types.h
index 7d1e498..16c970d 100644
--- a/libass/ass_types.h
+++ b/libass/ass_types.h
@@ -59,6 +59,7 @@ typedef struct font_provider_funcs {
CheckGlyphFunc check_glyph; // test codepoint for coverage
DestroyFontFunc destroy_font; // destroy a single font
DestroyProviderFunc destroy_provider; // destroy provider only
+ // XXX: add function for alias handling
} ASS_FontProviderFuncs;
/*